This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(chat): remove layout component and allow styling slots #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
November 22, 2018 15:39
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 88.32% 88.17% -0.15%
==========================================
Files 42 42
Lines 1456 1455 -1
Branches 212 212
==========================================
- Hits 1286 1283 -3
- Misses 165 167 +2
Partials 5 5
Continue to review full report at Codecov.
|
docs/src/examples/components/Chat/Types/ChatExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
bmdalex
commented
Nov 22, 2018
bmdalex
commented
Nov 22, 2018
sophieH29
reviewed
Nov 23, 2018
mnajdova
reviewed
Nov 23, 2018
docs/src/examples/components/Chat/Types/ChatExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
feat/chat-refactor
branch
from
November 23, 2018 16:50
c4c48e0
to
3ef7c1e
Compare
layershifter
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any other comments, LGTM 👍
kuzhelov
reviewed
Nov 26, 2018
docs/src/examples/components/Chat/Types/ChatMessageExampleStyled.shorthand.tsx
Show resolved
Hide resolved
kuzhelov
reviewed
Nov 26, 2018
kuzhelov
reviewed
Nov 26, 2018
kuzhelov
reviewed
Nov 26, 2018
kuzhelov
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, take a look on the comment related to message body's styles - other than that everything looks fine to me
bmdalex
force-pushed
the
feat/chat-refactor
branch
from
November 26, 2018 11:46
3ef7c1e
to
b3df78d
Compare
- added correct modifiers for methods
bmdalex
force-pushed
the
feat/chat-refactor
branch
from
November 26, 2018 11:57
b3df78d
to
f37ac17
Compare
kuzhelov
approved these changes
Nov 26, 2018
This was referenced Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(chat): remove layout component and allow styling slots
Description
This PR includes the following changes:
1. Refactors the render function for
Chat.Message
component to not useLayout
componentLayout
component does not allow the users to achieve proper styling of slots and it introduces a lot of unnecessary DOM nodes; we are usingSlot
instead.2. Reduces the size of the tree for
Chat.Message
by 50% (from 6 to 3):3. Adds functionality for targeting all subcomponents of
Chat.Message
:avatar
;messageBody
than containsauthor
,timestamp
andcontent
;4. Docs example:
For showing the users the
Chat.Message
anatomy and how they can style every slot:5. Styles (see short demo below):
messageBody
instead of the wholeChat.Message
)messageBody
;