-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This PR will be never merged. Using it to prove some ideas. |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=========================================
Coverage ? 88.17%
=========================================
Files ? 42
Lines ? 1455
Branches ? 212
=========================================
Hits ? 1283
Misses ? 167
Partials ? 5
Continue to review full report at Codecov.
|
8d5292c
to
b0ae1dd
Compare
docs/src/views/ColorPalette.tsx
Outdated
|
||
<Header as="h2">Text colors</Header> | ||
<p> | ||
Text variants are also separated as state color because in the most cases it's not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reading this as a client, and have a reasonable question: text color is largely influenced by the backgeround where text is used, but thjis paragraph suggests that there is only single text color suggested (yes, maybe with several tints, but still just a single color) - and this contradicts most approaches to color palette where text color is largely defined by the background - and, thus, on
variants for text color (generally - content color, such as text, icons, etc) are suggested: onPrimary
, onSecondary
, etc. More than that, depending on the tint of the background different text color might be used, so that content will appear with enough visual contrast.
What is our suggestion here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, might suggest to rename it to something that is more generic than text
, as this color generally applies not only to text content
one thing that I still missing, even after reading the guide, is what are the steps I should follow as a client to introduce color palette to my theme? What are the tools that will aid me in that? If it is not the purpose of this PR - please, let me know what are our steps planned to address that? |
679e468
to
526b020
Compare
0fd3d59
to
a75ce5e
Compare
Fixes #423.