Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

docs: add transparent button to examples #407

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Oct 26, 2018

Expected

The Segment should have a background color to appear solid.

image

Actual

The segment only has a border and shadow 😞

image

Problem

This was never noticed because the example card includes a background color:

image

Fix

The docs now include a "Transparent" button on each example. We should use this liberally when designing components.

Toggling the example to transparent mode clearly shows the issue:

http://g.recordit.co/u77ahMh1Vl.gif

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          41       41           
  Lines        1341     1341           
  Branches      172      197   +25     
=======================================
  Hits         1230     1230           
  Misses        107      107           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4313e...759913c. Read the comment docs.

@levithomason levithomason merged commit 79ba776 into master Oct 29, 2018
@levithomason levithomason deleted the docs/transparent branch October 29, 2018 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants