Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(list): enter and spacebar keyboard handling for List and Listitem #279

Merged
merged 11 commits into from
Dec 20, 2018

Conversation

jurokapsiar
Copy link
Contributor

This PR adds focus zone and Enter/Space keyboard handlers to selection list.

@jurokapsiar jurokapsiar changed the title feat/roles and keyboard handlers for list and listitem feat(list):Roles and keyboard handlers for list and listitem Sep 26, 2018
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #279 into master will increase coverage by 1.03%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #279      +/-   ##
========================================
+ Coverage   87.96%    89%   +1.03%     
========================================
  Files          42     41       -1     
  Lines        1404   1391      -13     
  Branches      183    202      +19     
========================================
+ Hits         1235   1238       +3     
+ Misses        165    149      -16     
  Partials        4      4
Impacted Files Coverage Δ
src/components/List/ListItem.tsx 100% <100%> (ø) ⬆️
src/components/Chat/Chat.tsx 91.3% <0%> (-4.35%) ⬇️
src/components/Accordion/AccordionTitle.tsx 63.15% <0%> (-1.85%) ⬇️
src/components/Accordion/AccordionContent.tsx 78.57% <0%> (-1.43%) ⬇️
src/components/Accordion/Accordion.tsx 65.3% <0%> (-0.7%) ⬇️
src/components/Icon/Icon.tsx 83.33% <0%> (-0.67%) ⬇️
src/components/Menu/MenuItem.tsx 80% <0%> (-0.49%) ⬇️
src/components/ItemLayout/ItemLayout.tsx 82.6% <0%> (-0.38%) ⬇️
src/components/Header/Header.tsx 94.44% <0%> (-0.3%) ⬇️
src/components/Button/Button.tsx 95.74% <0%> (-0.09%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3759e68...e93683f. Read the comment docs.

@kuzhelov kuzhelov changed the title feat(list):Roles and keyboard handlers for list and listitem feat(list): roles and keyboard handlers for List and Listitem Sep 26, 2018
@kolaps33
Copy link
Collaborator

When I tried to navigate into the list with
Virtual cursor/JAWS and Browse Mode/NVDA list did not get focus at all.

Figure out that it causing the role='presentation' which is generated on the div about the list.

Find out if JAWS user navigate to listbox with virtual cursor, then need to press space activate navigation in listbox:
https://jfw.groups.io/g/main/topic/selecting_in_a_list_box_jaws/5608353?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,5608353

@jurokapsiar jurokapsiar changed the title feat(list): roles and keyboard handlers for List and Listitem feat(list): enter and spacebar keyboard handling for List and Listitem Nov 8, 2018
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NITs, we need to resolve merge conflicts there and ship it 👍

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@jurokapsiar jurokapsiar merged commit e93076c into master Dec 20, 2018
@jurokapsiar jurokapsiar deleted the feat/list-accessibility branch December 20, 2018 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants