Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Debug): Check that owner exists #2055

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Conversation

miroslavstastny
Copy link
Member

When showing a debug panel, check that debug owner exists.

Debug owner is the component which rendered the debugged component. There are cases where the debug owner is not in the React tree. Consider the following example:

const icon = <Icon name="call" />
const ButtonExample = () => <Button icon={() => icon} content="Click here" />

If that is rendered as an example in DocSite using ComponentExample, debug owner is not found.

@miroslavstastny miroslavstastny merged commit 9be8eb1 into master Oct 23, 2019
@miroslavstastny miroslavstastny deleted the fix/debug-check-owner branch October 23, 2019 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants