This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
perf: cache component variables #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
layershifter and
levithomason
as code owners
packages/react/src/types.ts
Outdated
| @@ -168,4 +168,5 @@ export interface ProviderContextPrepared { | |||
| target: Document | |||
| theme: ThemePrepared | |||
| originalThemes: (ThemeInput | undefined)[] | |||
| resolvedComponentVariables: Record<string, object> | |||
There was a problem hiding this comment.
Suggested change
| resolvedComponentVariables: Record<string, object> | |
| DO_NOT_USE_OR_YOU_WILL_BE_FIRED_resolvedComponentVariables: Record<string, object> |
There was a problem hiding this comment.
would _internal_resolvedComponentVariables be enough?
| props.variables && withDebugId(props.variables, 'props.variables'), | ||
| )(theme.siteVariables) | ||
| // Resolve variables for this component, cache the result in provider | ||
| if (!(displayName in resolvedComponentVariables)) { |
There was a problem hiding this comment.
Suggested change
| if (!(displayName in resolvedComponentVariables)) { | |
| if (!resolvedComponentVariables[displayName]) { |
If there difference between this?
There was a problem hiding this comment.
yes, they are completely opposite :-P
other than that, yes:
but because of the || {} on line 183, this is no longer necessary
| resolvedComponentVariables[displayName], | ||
| withDebugId(props.variables, 'props.variables'), | ||
| )(theme.siteVariables) | ||
| : resolvedComponentVariables[displayName] |
There was a problem hiding this comment.
nit, it's hard to read this, I suggest
let resolvedVariables = resolvedComponentVariables[displayName]
if (props.variables) {
resolvedVariables = mergeComponentVariables(
resolvedComponentVariables[displayName],
withDebugId(props.variables, 'props.variables'),
)(theme.siteVariables)
}There was a problem hiding this comment.
I don't like let.
layershifter
approved these changes
Oct 18, 2019
jurokapsiar
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not resolve component variables in each render.
Resolved variables are now cached in
ProviderContext. NestedProviderstarts with an empty cache.Performance: