This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
perf(Tooltip): fix Popper positioning called when unnecessary #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
September 3, 2019 12:21
Codecov Report
@@ Coverage Diff @@
## master #1882 +/- ##
==========================================
+ Coverage 69.7% 69.71% +0.01%
==========================================
Files 886 886
Lines 7797 7800 +3
Branches 2285 2285
==========================================
+ Hits 5435 5438 +3
Misses 2352 2352
Partials 10 10
Continue to review full report at Codecov.
|
layershifter
reviewed
Sep 3, 2019
layershifter
reviewed
Sep 3, 2019
layershifter
approved these changes
Sep 3, 2019
Closed
layershifter
pushed a commit
that referenced
this pull request
Sep 3, 2019
(cherry picked from commit f74a0b9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1880