This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(QuickStart): improve code example #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
=======================================
Coverage 69.79% 69.79%
=======================================
Files 872 872
Lines 7498 7498
Branches 2180 2204 +24
=======================================
Hits 5233 5233
Misses 2257 2257
Partials 8 8Continue to review full report at Codecov.
|
silviuaavram
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code example at the bottom of QuickStart page was quite strange, as it didn't correspond to the
Buttonbelow it. Relevant issue #1759. Since the docs website is using FontAwesome icons, while the code examples use Teams icons, I have decided to make the example independent of the button below it.