This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone): Elements with contenteditable attribute should be respected on Home/End key press
#1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espected on Home/End key press
sophieH29
added
🚀 ready for review
🧰 fix
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
=========================================
+ Coverage 69.94% 70% +0.05%
=========================================
Files 868 868
Lines 7347 7351 +4
Branches 2141 2121 -20
=========================================
+ Hits 5139 5146 +7
+ Misses 2202 2199 -3
Partials 6 6
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Aug 2, 2019
|
Is it possible to add test(s) for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1608
When pressing
Home\Endkeys, focus should not move out of element withcontenteditableattribute.