Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(MenuButton): add component #1696

Merged
merged 17 commits into from
Aug 8, 2019
Merged

feat(MenuButton): add component #1696

merged 17 commits into from
Aug 8, 2019

Conversation

jurokapsiar
Copy link
Contributor

@jurokapsiar jurokapsiar commented Jul 22, 2019

Allows opening a "dropdown" menu on left/right click, hover or focus.
Reuses Popup, adds a Menu to its content.

Fixes #345

@jurokapsiar jurokapsiar changed the title feat(Component): ContextMenu feat(Component): MenuButton Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #1696 into master will decrease coverage by 0.04%.
The diff coverage is 62.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
- Coverage   69.94%   69.89%   -0.05%     
==========================================
  Files         863      867       +4     
  Lines        7286     7338      +52     
  Branches     2110     2147      +37     
==========================================
+ Hits         5096     5129      +33     
- Misses       2183     2201      +18     
- Partials        7        8       +1
Impacted Files Coverage Δ
packages/react/src/index.ts 100% <ø> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 65.71% <ø> (ø) ⬆️
...ckages/react/src/components/Popup/PopupContent.tsx 95.45% <100%> (+14.5%) ⬆️
packages/react/src/components/Menu/Menu.tsx 71.79% <100%> (+0.74%) ⬆️
...ages/react/test/specs/behaviors/testDefinitions.ts 89.53% <100%> (ø) ⬆️
...ages/react/src/lib/getOrGenerateIdFromShorthand.ts 100% <100%> (ø) ⬆️
...lib/accessibility/Behaviors/Popup/popupBehavior.ts 93.75% <100%> (ø) ⬆️
...ibility/Behaviors/MenuButton/menuButtonBehavior.ts 100% <100%> (ø)
...ages/react/src/components/MenuButton/focusUtils.ts 20% <20%> (ø)
...es/teams/components/MenuButton/menuButtonStyles.ts 33.33% <33.33%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e53a4...56ce798. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging August 8, 2019 10:46 Inactive
@layershifter layershifter changed the title feat(Component): MenuButton feat(MenuButton): add component Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new component Component planned to be added to Stardust 🚀 ready for review RFC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] ContextMenu Component
4 participants