-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Icon): add no-audio icon to Teams theme #1598
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
+ Coverage 71.53% 71.68% +0.15%
==========================================
Files 847 848 +1
Lines 6931 6916 -15
Branches 1977 1965 -12
==========================================
Hits 4958 4958
+ Misses 1967 1952 -15
Partials 6 6
Continue to review full report at Codecov.
|
Do you want me to do that as part of this PR or you will followup with @codepretty and do it separately later? |
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/index-new.ts
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-no-audio.tsx
Outdated
Show resolved
Hide resolved
If we're talking about this icon, then please remove. It is deprecated. |
I think we will want to name all the icons like this simliarly, so i would suggest instead of naming it |
Renamed. |
Removed outdated icon |
@codepretty, @notandrew, please, make another review round to verify the changes. Thank you! |
This pull request is automatically deployed with Now. Latest deployment for this branch: https://stardust-react-git-fork-amramornov-ms-master.stardust-ui.now.sh |
Adding new icon which is required for pre-join screen in Teams: