Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Icon): add no-audio icon to Teams theme #1598

Merged
merged 5 commits into from
Jul 10, 2019

Conversation

amramornov-ms
Copy link
Contributor

@amramornov-ms amramornov-ms commented Jul 8, 2019

Adding new icon which is required for pre-join screen in Teams:

image image

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1598 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   71.53%   71.68%   +0.15%     
==========================================
  Files         847      848       +1     
  Lines        6931     6916      -15     
  Branches     1977     1965      -12     
==========================================
  Hits         4958     4958              
+ Misses       1967     1952      -15     
  Partials        6        6
Impacted Files Coverage Δ
...es/teams/components/Icon/svg/icons/speakerMute.tsx 100% <100%> (ø)
...nts/Icon/svg/ProcessedIcons/icons-speaker-mute.tsx 100% <100%> (ø)
packages/react/src/themes/teams/colors.ts 76.47% <0%> (ø) ⬆️
...eams/components/Tooltip/tooltipContentVariables.ts 0% <0%> (ø) ⬆️
...hemes/teams/components/Tooltip/tooltipVariables.ts 0% <0%> (ø) ⬆️
...ackages/react/src/components/Provider/Provider.tsx 95.34% <0%> (ø) ⬆️
packages/react/src/themes/teams/pointerSvgUrl.ts
...gh-contrast/components/Tooltip/tooltipVariables.ts 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20f4a4...7f16c51. Read the comment docs.

@amramornov-ms
Copy link
Contributor Author

I think that these changes make playsoundmute icon to be not relevant for us anymore - so that we could delete corresponding icons-play-sound-mute file, to avoid confusion in future.

FYI @codepretty

Do you want me to do that as part of this PR or you will followup with @codepretty and do it separately later?

@codepretty
Copy link
Collaborator

I think that these changes make playsoundmute icon to be not relevant for us anymore - so that we could delete corresponding icons-play-sound-mute file, to avoid confusion in future.
FYI @codepretty

Do you want me to do that as part of this PR or you will followup with @codepretty and do it separately later?

If we're talking about this icon, then please remove. It is deprecated.

image

@codepretty
Copy link
Collaborator

codepretty commented Jul 9, 2019

I think we will want to name all the icons like this simliarly, so i would suggest instead of naming it noaudio try speaker-mute or volume-mute instead.

@kuzhelov kuzhelov added the needs author changes Author needs to implement changes before merge label Jul 9, 2019
@amramornov-ms
Copy link
Contributor Author

I think we will want to name all the icons like this simliarly, so i would suggest instead of naming it noaudio try speaker-mute or volume-mute instead.

Renamed.

@amramornov-ms
Copy link
Contributor Author

I think that these changes make playsoundmute icon to be not relevant for us anymore - so that we could delete corresponding icons-play-sound-mute file, to avoid confusion in future.
FYI @codepretty

Do you want me to do that as part of this PR or you will followup with @codepretty and do it separately later?

If we're talking about this icon, then please remove. It is deprecated.

image

Removed outdated icon

@kuzhelov kuzhelov removed the needs author changes Author needs to implement changes before merge label Jul 9, 2019
@kuzhelov
Copy link
Contributor

kuzhelov commented Jul 9, 2019

@codepretty, @notandrew, please, make another review round to verify the changes. Thank you!

@vercel
Copy link

vercel bot commented Jul 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://stardust-react-git-fork-amramornov-ms-master.stardust-ui.now.sh

@kuzhelov kuzhelov merged commit 7365cf5 into microsoft:master Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants