Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Tooltip): Add accessibility attributes and keyboard handlers #1575

Merged
merged 8 commits into from
Jul 3, 2019

Conversation

sophieH29
Copy link
Contributor

Add ARIA attributes and keyboard handlers to Tooltip component

TODO:

  • update CHANGELOG

@sophieH29 sophieH29 added ⚙️ enhancement New feature or request accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jul 2, 2019
@sophieH29 sophieH29 self-assigned this Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #1575 into master will decrease coverage by 0.05%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   71.64%   71.58%   -0.06%     
==========================================
  Files         844      844              
  Lines        6891     6874      -17     
  Branches     1960     1949      -11     
==========================================
- Hits         4937     4921      -16     
+ Misses       1948     1947       -1     
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/components/Dialog/Dialog.tsx 31.57% <ø> (-13.11%) ⬇️
...ages/react/src/lib/getOrGenerateIdFromShorthand.ts 100% <100%> (ø)
...accessibility/Behaviors/Tooltip/tooltipBehavior.ts 100% <100%> (ø)
packages/react/src/components/Tooltip/Tooltip.tsx 63.76% <50%> (-0.85%) ⬇️
...ges/react/src/components/Attachment/Attachment.tsx 42.3% <0%> (-35.48%) ⬇️
packages/react/src/components/Toolbar/Toolbar.tsx 89.47% <0%> (-1.01%) ⬇️
packages/react/src/index.ts 100% <0%> (ø) ⬆️
...hemes/teams/components/Toolbar/toolbarVariables.ts 50% <0%> (ø) ⬆️
...eams/components/Toolbar/toolbarCustomItemStyles.ts
...react/src/components/Toolbar/ToolbarCustomItem.tsx
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb2459...030c0ca. Read the comment docs.

@jurokapsiar
Copy link
Contributor

looks good, we'll do some tests with screen readers today

@sophieH29 sophieH29 merged commit 644f816 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/tooltip-a11y-behavior-aria branch July 3, 2019 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. ⚙️ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants