This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Tooltip): Add accessibility attributes and keyboard handlers #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
added
⚙️ enhancement
New feature or request
accessibility
All the Accessibility tasks and bugs should be tagged with this.
labels
Jul 2, 2019
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
July 2, 2019 16:50
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
- Coverage 71.64% 71.58% -0.06%
==========================================
Files 844 844
Lines 6891 6874 -17
Branches 1960 1949 -11
==========================================
- Hits 4937 4921 -16
+ Misses 1948 1947 -1
Partials 6 6
Continue to review full report at Codecov.
|
looks good, we'll do some tests with screen readers today |
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
approved these changes
Jul 3, 2019
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
jurokapsiar
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accessibility
All the Accessibility tasks and bugs should be tagged with this.
⚙️ enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ARIA attributes and keyboard handlers to
Tooltip
componentTODO: