This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs: create a visible Best Practices section for each component #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinais
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
alinais
changed the title
…ui/react into docs/add-dos-and-donts
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
=======================================
Coverage 71.53% 71.53%
=======================================
Files 848 848
Lines 6932 6932
Branches 1997 1977 -20
=======================================
Hits 4959 4959
Misses 1967 1967
Partials 6 6
Continue to review full report at Codecov.
|
jurokapsiar
reviewed
Jun 26, 2019
codepretty
reviewed
Jun 26, 2019
| const doList = [ | ||
| { | ||
| key: 'one', | ||
| content: 'Choose desired accessibility behavior depending on the use case.', |
There was a problem hiding this comment.
Would it be helpful to add examples of what use cases would use which behaviors?
There was a problem hiding this comment.
@jurokapsiar, can you please provide some short examples?
codepretty
reviewed
Jun 26, 2019
docs/src/examples/components/Popup/BestPractices/PopupBestPractices.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jun 26, 2019
docs/src/examples/components/Popup/BestPractices/PopupBestPractices.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Jun 26, 2019
docs/src/examples/components/Reaction/BestPractices/ReactionBestPractices.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jul 1, 2019
docs/src/examples/components/Accordion/BestPractices/AccordionBestPractices.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jul 1, 2019
kuzhelov
reviewed
Jul 1, 2019
docs/src/examples/components/Dropdown/BestPractices/DropdownBestPractices.tsx
Outdated
Show resolved
Hide resolved
…b.com/stardust-ui/react into docs/add-dos-and-donts
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://stardust-react-git-docs-add-dos-and-donts.stardust-ui.now.sh |
kuzhelov
reviewed
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
