This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(plugins): use compiled dependency instead of css-expand-shorthand
#1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Jun 25, 2019
| @@ -32,24 +31,14 @@ | |||
| </style> | |||
| </head> | |||
| <body> | |||
| <script src="https://cdn.jsdelivr.net/npm/@babel/polyfill@7/dist/polyfill.min.js"></script> | |||
| <script src='https://cdn.jsdelivr.net/npm/core-js-bundle/minified.js'></script> | |||
| <script src='https://cdn.jsdelivr.net/npm/whatwg-fetch/dist/fetch.umd.min.js'></script> | |||
There was a problem hiding this comment.
fetch() is not supported by IE11
layershifter
commented
Jun 25, 2019
| @@ -32,24 +31,14 @@ | |||
| </style> | |||
| </head> | |||
| <body> | |||
| <script src="https://cdn.jsdelivr.net/npm/@babel/polyfill@7/dist/polyfill.min.js"></script> | |||
| <script src='https://cdn.jsdelivr.net/npm/core-js-bundle/minified.js'></script> | |||
There was a problem hiding this comment.
core-js-bundle is bundled version of core-js which is a successor for @babel/polyfill:
https://babeljs.io/docs/en/babel-polyfill
layershifter
commented
Jun 25, 2019
| <script | ||
| crossOrigin="anonymous" | ||
| src="https://unpkg.com/prettier@<%= htmlWebpackPlugin.options.versions.prettier %>/parser-typescript.js" | ||
| src="https://cdn.jsdelivr.net/combine/npm/prettier@<%= htmlWebpackPlugin.options.versions.prettier %>/standalone.min.js,npm/prettier@<%= htmlWebpackPlugin.options.versions.prettier %>/parser-babylon.min.js,npm/prettier@<%= htmlWebpackPlugin.options.versions.prettier %>/parser-html.min.js,npm/prettier@<%= htmlWebpackPlugin.options.versions.prettier %>/parser-typescript.min.js" |
There was a problem hiding this comment.
Instead of 4 files unminified files from CDN we will require only minified one 🚤
layershifter
commented
Jun 25, 2019
| @@ -62,7 +51,8 @@ | |||
|
|
|||
| <script src="https://cdn.jsdelivr.net/npm/@babel/standalone@<%= htmlWebpackPlugin.options.versions.babelStandalone %>/babel.min.js"></script> | |||
|
|
|||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/prismjs@1.16.0/themes/prism-tomorrow.css"> | |||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/prismjs@1.16.0/themes/prism-tomorrow.min.css"> | |||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/react-vis@<%= htmlWebpackPlugin.options.versions.reactVis %>/dist/style.min.css" /> | |||
There was a problem hiding this comment.
Also minified versions
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
==========================================
- Coverage 73.16% 71.82% -1.35%
==========================================
Files 828 829 +1
Lines 6227 6697 +470
Branches 1786 1898 +112
==========================================
+ Hits 4556 4810 +254
- Misses 1666 1882 +216
Partials 5 5
Continue to review full report at Codecov.
|
layershifter
commented
Jun 25, 2019
| zIndex: 100, | ||
| }} | ||
| title={copyable ? 'Copy' : undefined} | ||
| > | ||
| <div>{label || mode}</div> | ||
| {copyable && <div style={{ marginLeft: '5px' }}>{active ? '✔ ' : '⎘'}</div>} | ||
| {copyable && <div style={{ marginLeft: '5px' }}>{active ? checkIcon : copyIcon}</div>} |
There was a problem hiding this comment.
Current icon looks ugly and there are no good replacement, so I decided to use SVGs.
Also it's not enough contrast, so change color to #ccc from PrismJS theme.
After
miroslavstastny
approved these changes
Jun 25, 2019
…dust-ui/react into fix/ie11-dep # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534.
Problem
IE11 does not have support of arrow functions while our dependency
css-shorthand-expandhas its usage. And for client there is only one option to fix - compile these dependency withbabel-loaderor any other thing 👎Solution
I used
@pika/packto quicky get bundled library, so ourcssExpandShorthand.tscontainscss-shorthand-expandand all its dependencies in the single and tree-shaken file. As we compile all our files with Babel: arrow functions and any other unsupported things will be compiled properly 🚀