This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(attachmentBehavior): add "data-is-focusable" for attachment #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
added
⚙️ enhancement
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 805 805
Lines 6073 6073
Branches 1775 1775
=======================================
Hits 4442 4442
Misses 1625 1625
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
reviewed
Jun 3, 2019
packages/react/src/lib/accessibility/Behaviors/Attachment/attachmentBehavior.ts
Outdated
Show resolved
Hide resolved
…chmentBehavior.ts Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
layershifter
approved these changes
Jun 3, 2019
bmdalex
approved these changes
Jun 4, 2019
delete-merged-branch
bot
deleted the
feat/add-data-is-focusable-attachment
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1397
When attachment component is used in a bigger scope, as in chat message, then "focus zone" doesn't navigate into attachment