-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 73.59% 73.68% +0.08%
==========================================
Files 787 787
Lines 5890 5906 +16
Branches 1738 1721 -17
==========================================
+ Hits 4335 4352 +17
+ Misses 1549 1548 -1
Partials 6 6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
=========================================
+ Coverage 73.53% 73.6% +0.07%
=========================================
Files 787 787
Lines 5894 5907 +13
Branches 1742 1744 +2
=========================================
+ Hits 4334 4348 +14
+ Misses 1554 1553 -1
Partials 6 6
Continue to review full report at Codecov.
|
f206637
to
162be80
Compare
@@ -247,7 +247,6 @@ class MenuItem extends AutoControlledComponent<WithAsProp<MenuItemProps>, MenuIt | |||
align={vertical ? 'top' : 'start'} | |||
position={vertical ? 'after' : 'below'} | |||
targetRef={this.itemRef} | |||
modifiers={{ flip: { flipVariationsByContent: true } }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed as this modifier is applied by default now
8943460
to
c30fbcc
Compare
…i/react into fix/popper-flickering
fix(popper): flickering
Fixes #1415
Fixes #1361
Description
Popup content jumps for a split second when opening.
Perform the following steps to reproduce the problem:
Popup
examples page: http://localhost:8080/components/popup#types-popupPopup
Expected Result
Popup opens without jump
Actual Result
Popup has a small but noticeable jump when opening (see gif below) 💣
Proposed fix
Create the
PopperJS
instance earlier, aka immediately after we get aref
to thechildren
prop that thepopper.js
box is going to display: