This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348
This PR addresses the issue of expected behavior of
<Flex fill />
, and makes it aligned with the behavior suggested by spec:BREAKING CHANGES
Effect of this fix is changed behavior of
fill
prop ofFlex
component in case if it is a child of otherFlex
.If client would like to preserve this look, i.e. inner
Flex
to take only the minimal width necessary (and not the entire space provided by outerFlex
), thenfill
prop should be removed for innerFlex
vAlign=stretch
prop to outerFlex
Description
From https://codesandbox.io/s/ulrbd?module=/example.js :
Was
Now