This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(dialogs): themeing support for Teams dark and hc #1297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
May 7, 2019 04:22
codepretty
changed the title
fix(dialogs): basic themeing support for Teams dark and hc
fix(dialogs): themeing support for Teams dark and hc
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
=========================================
- Coverage 72.3% 72.2% -0.11%
=========================================
Files 764 769 +5
Lines 5769 5777 +8
Branches 1688 1712 +24
=========================================
Hits 4171 4171
- Misses 1592 1600 +8
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
reviewed
May 7, 2019
notandrew
reviewed
May 9, 2019
packages/react/src/themes/teams-high-contrast/components/Dialog/dialogStyles.ts
Show resolved
Hide resolved
packages/react/src/themes/teams-dark/components/Dialog/dialogVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Dialog/dialogVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Dialog/dialogStyles.ts
Outdated
Show resolved
Hide resolved
miroslavstastny
approved these changes
May 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment added, other than that 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1313.
This does not include all the redline work for Dialogs. This is just to fix the Dialog's color support in Teams dark and Teams high contrast themes.
Screenshots below (Before | After)
Teams theme
Teams dark theme
Teams high contrast theme