Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): Fix routing for accessibility documentation #1208

Merged
merged 4 commits into from
Apr 11, 2019

Conversation

sophieH29
Copy link
Contributor

When heading navigation within the article was implemented initially for Accessibility documentation, there were "/" sign added to each link. Since deployed version has a different route /react/, these links were rewriting /react/ part what caused 404 error when navigating.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #1208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files         751      751           
  Lines        8854     8854           
  Branches     1178     1178           
=======================================
  Hits         7309     7309           
  Misses       1530     1530           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2b172...8e70832. Read the comment docs.

Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

</ul>
</li>
<li>
{link('Keyboard Navigation', '/accessibility#keyboard-navigation')}
{link('Keyboard Navigation', 'accessibility#keyboard-navigation')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that those are the links to the same page, suggest to use just id selector as their content - this would solve all the maintainability headache:

{link('Keyboard Navigation', '#keyboard-navigation')}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried that approach, unfortunately, it does not work that way. That query part is not added to the end but rewrites the path

@miroslavstastny
Copy link
Member

There are anchor links next to each header on the page which are broken as well:
image

@sophieH29
Copy link
Contributor Author

sophieH29 commented Apr 11, 2019

There are anchor links next to each header on the page which are broken as well:
image

They're broken across all pages. I think a separate PR should be addressed to fix that issue. Filed a bug #1210

@sophieH29 sophieH29 merged commit ee3c442 into master Apr 11, 2019
@sophieH29 sophieH29 deleted the docs/fix-routing branch April 11, 2019 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants