This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): fix code example of theming guide #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 740 740
Lines 8754 8754
Branches 1170 1236 +66
=======================================
Hits 7220 7220
Misses 1519 1519
Partials 15 15Continue to review full report at Codecov.
|
layershifter
reviewed
Apr 9, 2019
docs/src/views/ThemingExamples.tsx
Outdated
|
|
||
| export default () => | ||
| <Provider> | ||
| <Provider theme={themes.teams}> | ||
| <> |
There was a problem hiding this comment.
nit: We don't need Fragment there more
layershifter
approved these changes
Apr 9, 2019
miroslavstastny
approved these changes
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1110 .