Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Grid|Image): move styles to base theme #1182

Merged
merged 7 commits into from
Apr 8, 2019
Merged

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 5, 2019

Moved Grid's and Image's styles and variables to base theme. Added circularRadius variable in the Image's variables.

@mnajdova mnajdova changed the title [WIP] feat(Grid|Image): move styles to base theme feat(Grid|Image): move styles to base theme Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1182 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   82.46%   82.46%   -0.01%     
==========================================
  Files         735      735              
  Lines        8724     8723       -1     
  Branches     1169     1235      +66     
==========================================
- Hits         7194     7193       -1     
  Misses       1514     1514              
  Partials       16       16
Impacted Files Coverage Δ
packages/react/src/themes/teams/componentStyles.ts 100% <ø> (ø) ⬆️
...kages/react/src/themes/teams/componentVariables.ts 100% <ø> (ø) ⬆️
...t/src/themes/base/components/Grid/gridVariables.ts 100% <ø> (ø)
...eact/src/themes/base/components/Grid/gridStyles.ts 13.33% <ø> (ø)
...src/themes/base/components/Image/imageVariables.ts 100% <ø> (ø)
...ct/src/themes/base/components/Image/imageStyles.ts 14.28% <0%> (ø)
...ckages/react/src/themes/base/componentVariables.ts 100% <100%> (ø) ⬆️
packages/react/src/themes/base/componentStyles.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348d06a...423290f. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG? 🤔

@mnajdova mnajdova merged commit b1ff006 into master Apr 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/grid-base-theme branch April 8, 2019 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants