Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(chatBehavior): Use FocusZone mode Embed instead of Wrap #1044

Merged
merged 4 commits into from
Mar 12, 2019

Conversation

sophieH29
Copy link
Contributor

FocusZone renders redundant

in Wrap mode for chat. This PR changes mode to Embed to simplify HTML structure

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #1044 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage   81.77%   81.71%   -0.06%     
==========================================
  Files         687      687              
  Lines        8822     8822              
  Branches     1566     1566              
==========================================
- Hits         7214     7209       -5     
- Misses       1593     1598       +5     
  Partials       15       15
Impacted Files Coverage Δ
...c/lib/accessibility/Behaviors/Chat/chatBehavior.ts 92.85% <ø> (+7.14%) ⬆️
packages/react/src/lib/renderComponent.tsx 92.59% <0%> (-4.94%) ⬇️
...ct/test/specs/commonTests/handlesAccessibility.tsx 83.09% <0%> (-1.41%) ⬇️
...ages/react/test/specs/commonTests/isConformant.tsx 93.08% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192877b...f08e71a. Read the comment docs.

@layershifter
Copy link
Member

Changelog entry?

@@ -17,7 +17,7 @@ const ChatBehavior: Accessibility = (props: any) => ({
},
},
focusZone: {
mode: FocusZoneMode.Wrap,
mode: FocusZoneMode.Embed,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog entry :)

@sophieH29 sophieH29 merged commit bf5ac50 into master Mar 12, 2019
@sophieH29 sophieH29 deleted the fix/chat-behavior-focus-zone-embed branch March 12, 2019 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants