From be1cb12dba749ce81c01317993868615c0a734a9 Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 13:26:44 +0300 Subject: [PATCH 1/7] Added in field options "Page View" event --- template.tpl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/template.tpl b/template.tpl index 68eb8b5..c96b274 100644 --- a/template.tpl +++ b/template.tpl @@ -105,6 +105,10 @@ ___TEMPLATE_PARAMETERS___ { "value": "Subscribe", "displayValue": "Subscribe" + }, + { + "value": "Pageview", + "displayValue": "Page View" } ], "simpleValueType": true, From 972ea44170abfc71e14340a2b8475d2914f5c755 Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 13:28:53 +0300 Subject: [PATCH 2/7] Revert "Added in field options "Page View" event" This reverts commit be1cb12dba749ce81c01317993868615c0a734a9. --- template.tpl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/template.tpl b/template.tpl index c96b274..68eb8b5 100644 --- a/template.tpl +++ b/template.tpl @@ -105,10 +105,6 @@ ___TEMPLATE_PARAMETERS___ { "value": "Subscribe", "displayValue": "Subscribe" - }, - { - "value": "Pageview", - "displayValue": "Page View" } ], "simpleValueType": true, From 6360ba32f222d1d7894632e1855d72698e4f067b Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 13:35:26 +0300 Subject: [PATCH 3/7] Added event type "Page View" and fixed inherit option for Page View --- template.tpl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/template.tpl b/template.tpl index 68eb8b5..d7d0a73 100644 --- a/template.tpl +++ b/template.tpl @@ -105,6 +105,10 @@ ___TEMPLATE_PARAMETERS___ { "value": "Subscribe", "displayValue": "Subscribe" + }, + { + "value": "Pageview", + "displayValue": "Page View" } ], "simpleValueType": true, @@ -988,12 +992,12 @@ function getEventName(eventData, data) { let eventName = eventData.event_name; let gaToEventName = { - page_view: 'PageView', + page_view: 'Pageview', click: 'ClickButton', download: 'Download', file_download: 'Download', complete_registration: 'CompleteRegistration', - 'gtm.dom': 'PageView', + 'gtm.dom': 'Pageview', add_payment_info: 'AddPaymentInfo', add_to_cart: 'AddToCart', add_to_wishlist: 'AddToWishlist', From 7b94afcd8c95210ac6bf1b4a5c2af9bfeb84dc32 Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 17:14:46 +0300 Subject: [PATCH 4/7] Updated metadata --- metadata.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metadata.yaml b/metadata.yaml index c5e908c..44f3e89 100644 --- a/metadata.yaml +++ b/metadata.yaml @@ -1,5 +1,7 @@ homepage: "https://stape.io/" versions: + - sha: 6360ba32f222d1d7894632e1855d72698e4f067b + changeNotes: Added Page View event - sha: 6f6d47d9011bc247df34b08c0bafcd45d11fe3de changeNotes: Fix user data hashing. - sha: 3639d997b1a2d25404a82ddaa428e6af05aba1c0 From e618612e09af3192bbc41512bf918c686bca7cb3 Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 17:25:01 +0300 Subject: [PATCH 5/7] Updated js file --- template.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/template.js b/template.js index 377c25d..8c2d4cc 100644 --- a/template.js +++ b/template.js @@ -373,12 +373,12 @@ function getEventName(eventData, data) { let eventName = eventData.event_name; let gaToEventName = { - page_view: 'PageView', + page_view: 'Pageview', click: 'ClickButton', download: 'Download', file_download: 'Download', complete_registration: 'CompleteRegistration', - 'gtm.dom': 'PageView', + 'gtm.dom': 'Pageview', add_payment_info: 'AddPaymentInfo', add_to_cart: 'AddToCart', add_to_wishlist: 'AddToWishlist', From 3f0a634ab1082886bdf8667a37d99bc4a008548e Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 17:40:37 +0300 Subject: [PATCH 6/7] Changed default value for event field --- template.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template.tpl b/template.tpl index d7d0a73..172d522 100644 --- a/template.tpl +++ b/template.tpl @@ -119,7 +119,7 @@ ___TEMPLATE_PARAMETERS___ } ], "displayName": "Event Name", - "defaultValue": "ViewContent" + "defaultValue": "Pageview" } ] }, From c0e59ce6c87618614fd82e299254de894fd2f075 Mon Sep 17 00:00:00 2001 From: gvidoou Date: Tue, 24 Sep 2024 17:48:45 +0300 Subject: [PATCH 7/7] Updated metadata --- metadata.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata.yaml b/metadata.yaml index 44f3e89..82ad0c1 100644 --- a/metadata.yaml +++ b/metadata.yaml @@ -1,6 +1,6 @@ homepage: "https://stape.io/" versions: - - sha: 6360ba32f222d1d7894632e1855d72698e4f067b + - sha: 3f0a634ab1082886bdf8667a37d99bc4a008548e changeNotes: Added Page View event - sha: 6f6d47d9011bc247df34b08c0bafcd45d11fe3de changeNotes: Fix user data hashing.