Squiz.WhiteSpace.SuperfluousWhiteSpace ignoreBlankLines property ignores whitespace after single line comments #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsherwood
reviewed
Jan 4, 2018
| @@ -192,6 +192,7 @@ public function process(File $phpcsFile, $stackPtr) | |||
|
|
|||
| // Ignore blank lines if required. | |||
| if ($this->ignoreBlankLines === true | |||
| && trim($tokens[$stackPtr]['content']) === '' | |||
There was a problem hiding this comment.
Might be easier to just use && $tokens[$stackPtr]['code'] === T_WHITESPACE
There was a problem hiding this comment.
Done. (Commit amended)
…gnore blank lines Setting `ignoreBlankLines` to true, would now also cause the sniff to ignore single-line comments with superfluous whitespace at the end. Includes unit test
jrfnl
force-pushed
the
feature/bugfix-superfluous-whitespace-ignore-blank-lines
branch
from
8ac478d
to
5e70aeb
Compare
gsherwood
changed the title
|
Thanks for that change |
jrfnl
deleted the
feature/bugfix-superfluous-whitespace-ignore-blank-lines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
ignoreBlankLinestotrue, would also cause the sniff to ignore single-line comments with superfluous whitespace at the end.Includes unit test.