Update package.json to reflect supported node versions #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L2jLiga
reviewed
Jul 13, 2019
package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "url": "https://github.com/squaremo/amqp.node.git" | |||
| }, | |||
| "engines": { | |||
| "node": ">=0.8 <=9" | |||
| "node": ">=0.8 <=11" | |||
|
You'll need to rebase on master, which has a fix for the CI build (see #526). |
Thanks for the heads up. PR is rebased now |
|
@squaremo Thanks for the merge. Can you release a new version to npm? This will help resolve the engine strict issues in my CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the current
.travis.yml, node version 10, 11, 12 are supported. I have updated the package.json to reflect that. Otherwise amqplib fails to install when users have flagengine-strict=truein their .npmrc.