Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased SCRATCH buffer to 16 KiB #367

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Conversation

twatson83
Copy link

No description provided.

@michaelklishin
Copy link

This is a follow-up to #366. Thank you, @twatson83.

@squaremo I think this change is reasonable and should cover a lot of scenarios where large headers are used. I'd prefer to use this buffer size without making it configurable for some time, until we have evidence that enough users need it. WDYT?

@squaremo squaremo merged commit f485a2c into amqp-node:master Jul 27, 2017
@squaremo
Copy link
Collaborator

Hi Tim!

No objection to this -- it's a one-off buffer, so the size doesn't matter too much within bounds ("4K should be enough for anyone!").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants