allow ssl to be enabled for redis #221
Conversation
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 26c6cc9 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 26c6cc9: https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/3916 |
There was a problem hiding this comment.
there's no docs here on how to use this, but looking at https://redis-py.readthedocs.io/en/stable/connections.html#generic-client, there's all of these ssl arguments:
ssl=False, ssl_keyfile=None, ssl_certfile=None, ssl_cert_reqs='required', ssl_ca_certs=None, ssl_ca_path=None, ssl_ca_data=None, ssl_check_hostname=False, ssl_password=None, ssl_validate_ocsp=False, ssl_validate_ocsp_stapled=False, ssl_ocsp_context=None, ssl_ocsp_expected_cert=None,
don't you need all of those for this to be useful?
I think a better implementation here would be that we take everything in "arguments" and pass it along to redis, or at the very least, we use a list of params to do it.
this is already in gerrit so I'll just add it
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/3916 has been merged. Congratulations! :) |
No description provided.