Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Provider configuration to allow plain RPC URL property #180

Open
MidnightLightning opened this issue Oct 6, 2023 · 0 comments
Open

Comments

@MidnightLightning
Copy link

The SiweMessage.verify function takes an optional second parameter of additional options, which includes a provider property to include an EthersJS Provider. Additionally, the SiweMessage.validate function takes an EthersJS Provider as a second property.

If a project wishes to supply those parameters, they must include EthersJS as a dependency in their project. In all other use cases, the implementing application doesn't need to know about EthersJS at all. (somewhat related to #151)

I believe the key piece of data the SIWE needs from the client is what RPC endpoint to call in order to make on-chain requests. Can those parameters be changed to be string inputs of an RPC URL rather than full Provider objects? Or allow the provider property to be sent as a string or a Provider, so implementing clients can choose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant