Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB module is pulling all storage implementations #4327

Closed
RustedBones opened this issue Apr 25, 2022 · 0 comments · Fixed by #4857
Closed

SMB module is pulling all storage implementations #4327

RustedBones opened this issue Apr 25, 2022 · 0 comments · Fixed by #4857

Comments

@RustedBones
Copy link
Contributor

Depending on scio-smb pulls transitively all storage implementation dependencies for:

  • parquet
  • json
  • avro
  • tensorflow

TensorFlow dependencies alone are ~200Mb.

Users should only have the desired storage implementation in their classpath

SMB should either:

  • be available in the storage implementation themselves
  • mark storage impl dependencies as provided
  • have specific impl modules like
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set io implementation as provided for smb and parquet spotify/scio
1 participant
@RustedBones