fix: add logs in traps server for situations when incoming traps have wrong credentials #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekzyla
force-pushed
the
fix/log-trap-auth-errors
branch
from
55d84ea
to
9c5d43c
Compare
wojtekzyla
changed the title
ajasnosz
requested changes
Feb 7, 2024
wojtekzyla
force-pushed
the
fix/log-trap-auth-errors
branch
from
9c5d43c
to
2203de7
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #953 +/- ##
===========================================
- Coverage 84.32% 84.11% -0.21%
===========================================
Files 28 28
Lines 2022 2027 +5
===========================================
Hits 1705 1705
- Misses 317 322 +5 ☔ View full report in Codecov by Sentry. |
ajasnosz
requested changes
Feb 7, 2024
… wrong credentials fix: delete unwanted files fix: add logging of source device ip fix: log only necessary info fix: run pre-commit fix: update the troubleshooting documentation fix: add comment in code fix: fixes from pr review fix: fix typos in documentation
wojtekzyla
force-pushed
the
fix/log-trap-auth-errors
branch
from
2203de7
to
743687e
Compare
ajasnosz
approved these changes
Feb 8, 2024
|
🎉 This PR is included in version 1.10.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logging for snmp traps errors
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manual testing
Checklist