Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: maintenance #46

Merged
merged 3 commits into from
Mar 24, 2024
Merged

ci: maintenance #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f141546
ci: update actions/checkout fromv v2 to v4
flavorjones Mar 23, 2024
195f5eb
ci: add coverage for ruby 3.2 and 3.3
flavorjones Mar 23, 2024
554d38a
test: get to passing on JRuby
flavorjones Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
os: [ubuntu]
# We still kind of support Ruby 1.8.7
ruby: [2.7, "3.0", 3.1, head, jruby]
ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "head", "jruby"]

name: >-
${{matrix.os}}:ruby-${{matrix.ruby}}
Expand All @@ -24,7 +24,7 @@ jobs:

steps:
- name: Check out
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up ruby and bundle
uses: ruby/setup-ruby@v1
Expand Down
2 changes: 1 addition & 1 deletion test/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ def test_file(filename)

def sleep_until(time)
if (s = time - Time.now) > 0
sleep s
sleep s + 0.01
end
end
6 changes: 2 additions & 4 deletions test/test_http_cookie_jar.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ def test_nonexistent_store
end

def test_nonexistent_store_in_config
assert_raise_with_message(
ArgumentError,
/cookie store unavailable: :nonexistent, error: cannot load .*nonexistent_store/
) {
expected = /cookie store unavailable: :nonexistent, error: (cannot load|no such file to load) .*nonexistent_store/
assert_raise_with_message(ArgumentError, expected) {
HTTP::CookieJar.new(store: :nonexistent)
}
end
Expand Down
Loading