From 7988699601aec92f4f29474ef9ce7badc8b902ea Mon Sep 17 00:00:00 2001 From: Jonathan Budzenski Date: Tue, 28 Nov 2017 13:51:20 -0600 Subject: [PATCH] Add support for passing in node options via environment variable (#56) * Add support for passing in node options via environment variable * Split node options * semicolon --- packages/kbn-plugin-helpers/package.json | 1 + packages/kbn-plugin-helpers/tasks/start/start_action.js | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/kbn-plugin-helpers/package.json b/packages/kbn-plugin-helpers/package.json index 08d136c90b95a60..cb1f97e256f7f81 100644 --- a/packages/kbn-plugin-helpers/package.json +++ b/packages/kbn-plugin-helpers/package.json @@ -19,6 +19,7 @@ "lint": "eslint bin/ help/ tasks/" }, "dependencies": { + "argv-split": "^2.0.1", "commander": "^2.9.0", "del": "^2.2.2", "gulp-rename": "1.2.2", diff --git a/packages/kbn-plugin-helpers/tasks/start/start_action.js b/packages/kbn-plugin-helpers/tasks/start/start_action.js index 2c175ab3d08e62d..89cf22a0b8a3901 100644 --- a/packages/kbn-plugin-helpers/tasks/start/start_action.js +++ b/packages/kbn-plugin-helpers/tasks/start/start_action.js @@ -1,12 +1,15 @@ const execFileSync = require('child_process').execFileSync; const { join } = require('path'); +const split = require('argv-split'); module.exports = function (plugin, run, options) { options = options || {}; const cmd = 'node'; const script = join('scripts', 'kibana.js'); - let args = [script, '--dev', '--plugin-path', plugin.root]; + const nodeOptions = split(process.env.NODE_OPTIONS || ''); + + let args = nodeOptions.concat([script, '--dev', '--plugin-path', plugin.root]); if (Array.isArray(plugin.includePlugins)) { plugin.includePlugins.forEach((path) => {