Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1102 Support #20

Open
AusIV opened this issue Aug 9, 2018 · 1 comment
Open

EIP1102 Support #20

AusIV opened this issue Aug 9, 2018 · 1 comment

Comments

@AusIV
Copy link
Contributor

AusIV commented Aug 9, 2018

On November 2nd, Metmask is going to stop injecting web3 and switch to a postMessage request for a web3 provider. It would be great if SpaceSuit followed the same timelines.

@jamespic
Copy link
Collaborator

Yep, this sounds like a good thing.

It might also be an opportunity to make some of the settings more fine-grained - there are some sites that need compatibility hacks, and some that don't, and having the option to not use them on sites that don't need them would be good. Having different network configs for some sites could be useful too.

I may still leave an option in to stick with the current behaviour of always injecting. There are a lot of badly written dapps out there, that rely heavily on deprecated MetaMask features, and those dapps are probably not going to improve by November 2nd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants