Add net attribute, deprecate networking #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--networking has been replaced by --net=X in Docker 0.11
|
For now let's take this as-is. Would love to add per-version attribute support at some point, but clearing up the current PR/issue backlog. Maybe things will be much more stable now that Docker is at 1.0 😄 Thanks for the contribution! |
bflad
added a commit
that referenced
this pull request
Jun 24, 2014
Add net attribute, deprecate networking
bflad
added a commit
that referenced
this pull request
Jun 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--networking has been replaced by --net=X in Docker 0.11. This attempts to fix #150
This is the minimum viable fix for this. I have some other ideas but want to run them past smarter people first.
bridge, host, container:, or none? This makes things slightly harder to mess up but will require updates if more options appear in the future.netornetworkingavailable conditionally on the Docker version but at least as of now I didn't see a way to check that. Probably a worthwhile feature for the cookbook in general? I can try to implement that in a separate PR (would require determining that both client and server are >x.x).