[counterpoll] Display the correct default poll interval for watermark counters #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Feb 25, 2022
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
judyjoseph
pushed a commit
that referenced
this pull request
Mar 7, 2022
… counters (#2082) Signed-off-by: Neetha John <nejo@microsoft.com> sonic-net/sonic-swss#2031 updated the flex counter polling interval to 60s for watermark counters but the show command wasn't updated to reflect the correct default value What I did Display the correct poll interval for watermark related counters in the 'counterpoll show' command How I did it Update the default interval to be the same as the one updated by the Orchs How to verify it Issue "counterpoll show", the queue, pg and buffer pool watermark should show default 60s Updated the counterpoll unit tests to reflect the same
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 11, 2022
…watermark counters (#2091) This is to backport the changes in #2082 #2031 updated the flex counter polling interval to 60s for watermark counters but the show command wasn't updated to reflect the correct default value #### What I did Display the correct poll interval for watermark related counters in the 'counterpoll show' command #### How I did it Update the default interval to be the same as the one updated by the Orchs #### How to verify it Issue "counterpoll show", the queue, pg and buffer pool watermark should show default 60s Updated the counterpoll unit tests to reflect the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
sonic-net/sonic-swss#2031 updated the flex counter polling interval to 60s for watermark counters but the show command wasn't updated to reflect the correct default value
What I did
Display the correct poll interval for watermark related counters in the 'counterpoll show' command
How I did it
Update the default interval to be the same as the one updated by the Orchs
How to verify it
Issue "counterpoll show", the queue, pg and buffer pool watermark should show default 60s
Updated the counterpoll unit tests to reflect the same