[muxcable][show] enhance show mux status to show last switchover time #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Feb 24, 2022
What is the motivation for this PR? Stemming from sonic-net/sonic-utilities#1961 sonic-net/sonic-utilities#2067 New columns are added to show muxcable status outputp. Update show_cable_status to use --json to avoid parsing error. Checked other usage of show muxcable status in sonic-mgmt, it's either using --json already, or for logging, or the current parse approach is compatible. How did you do it? Update show_cable_status to use --json to avoid parsing error.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdahiya12
approved these changes
Mar 2, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 4, 2022
…#2067) #### What I did Enhance ```show muxcable status``` to show last switchover time as well sign-off: Jing Zhang zhangjing@microsoft.com #### Previous command output ``` ~$ show mux status PORT STATUS HEALTH ----------- -------- --------- Ethernet0 standby unhealthy Ethernet4 standby unhealthy Ethernet8 standby unhealthy Ethernet12 standby unhealthy Ethernet16 standby unhealthy Ethernet20 standby unhealthy Ethernet40 standby unhealthy Ethernet44 standby unhealthy Ethernet48 standby unhealthy Ethernet52 standby unhealthy Ethernet56 standby unhealthy Ethernet60 standby unhealthy Ethernet64 standby unhealthy Ethernet68 standby unhealthy Ethernet72 standby unhealthy Ethernet76 standby unhealthy Ethernet80 standby unhealthy Ethernet84 standby unhealthy Ethernet104 standby unhealthy Ethernet108 standby unhealthy Ethernet112 standby unhealthy Ethernet116 standby unhealthy Ethernet120 standby unhealthy Ethernet124 standby unhealthy ``` #### New command output ``` ~$ show mux status PORT STATUS HEALTH LAST_SWITCHOVER_TIME ----------- -------- --------- --------------------------- Ethernet0 standby unhealthy 2022-Feb-14 16:47:06.813350 Ethernet4 standby unhealthy 2022-Feb-14 16:47:07.309137 Ethernet8 standby unhealthy 2022-Feb-14 16:47:07.373696 Ethernet12 standby unhealthy 2022-Feb-14 16:47:06.430575 Ethernet16 standby unhealthy 2022-Feb-14 16:47:08.131454 Ethernet20 standby unhealthy 2022-Feb-14 16:47:07.180982 Ethernet40 standby unhealthy 2022-Feb-14 16:47:07.335020 Ethernet44 standby unhealthy 2022-Feb-14 16:47:07.222463 Ethernet48 standby unhealthy 2022-Feb-14 16:47:07.354632 Ethernet52 standby unhealthy 2022-Feb-14 16:47:06.826954 Ethernet56 standby unhealthy 2022-Feb-14 16:47:07.230414 Ethernet60 standby unhealthy 2022-Feb-14 16:47:07.235581 Ethernet64 standby unhealthy 2022-Feb-14 16:47:07.315676 Ethernet68 standby unhealthy 2022-Feb-14 16:47:08.544206 Ethernet72 standby unhealthy 2022-Feb-14 16:47:07.325918 Ethernet76 standby unhealthy 2022-Feb-14 16:47:07.368308 Ethernet80 standby unhealthy 2022-Feb-14 16:47:08.534758 Ethernet84 standby unhealthy 2022-Feb-14 16:47:07.824009 Ethernet104 standby unhealthy 2022-Feb-14 16:47:06.814654 Ethernet108 standby unhealthy 2022-Feb-14 16:47:07.340556 Ethernet112 standby unhealthy 2022-Feb-14 16:47:07.361900 Ethernet116 standby unhealthy 2022-Feb-14 16:47:06.820994 Ethernet120 standby unhealthy 2022-Feb-14 16:47:07.177181 Ethernet124 standby unhealthy 2022-Feb-14 16:47:06.837251 ```
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 16, 2022
Advance sonic-utilities submodule to include the following changes 98de850 [muxcable][show] enhance show mux status to show last switchover time sonic-net/sonic-utilities#2067 3da82d1 [show][muxcable] fix the sudo access error for show muxcable metrics sonic-net/sonic-utilities#2083 7acbadb [build] stop vstest in the Azure pipeline sonic-net/sonic-utilities#2098 3fed440 [show][config] add muxcable command line support for retrieve / reset ICMP packet loss data sonic-net/sonic-utilities#2094 aa21e3a [202012] [counterpoll] Display the correct default poll interval for watermark counters sonic-net/sonic-utilities#2091 Signed-off-by: Neetha John <nejo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enhance
show muxcable statusto show last switchover time as wellsign-off: Jing Zhang zhangjing@microsoft.com
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)