[Portsorch]: Add lag-name and oid map to counter table COUNTERS_PORT_NAME_MAP #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
May 22, 2018
lguohan
reviewed
May 24, 2018
| FieldValueTuple tuple(lag_alias, sai_serialize_object_id(lag_id)); | ||
| vector<FieldValueTuple> fields; | ||
| fields.push_back(tuple); | ||
| m_counterTable->set("", fields); |
There was a problem hiding this comment.
we need the remove part as well.
There was a problem hiding this comment.
The modification has been uploaded, please take a moment to review it. I want to continue uploading code here(sonic-swss), thanks.
lguohan
requested changes
May 24, 2018
… table COUNTERS_PORT_NAME_MAP
|
The remove part is added, please review! |
pavel-shirshov
approved these changes
Jul 12, 2018
stcheng
approved these changes
Jul 19, 2018
merge azure sonic-swss master
Delete the extra line left in the conflict resolution
|
Hi stcheng, please take a moment to review this pull request, we need this pfc-wd function; look forward to your reply, be grateful. |
|
the pfc wd code is not relavant is the PR. can you create a separate PR for the pfcwd support and for this PR only limit change to COUNTERS_PORT_NAME_MAP. |
lguohan
requested changes
Mar 15, 2019
|
Hi lguohan, I removed the pfc-wd code based on your suggestion. Now there is only COUNTERS_PORT_NAME_MAP related operation in this PR, please take a moment to deal with it, thanks. |
|
@lguohan Please help review this PR, thanks. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…t#510) * [fast/warm reboot] carve out variable setup code to a function Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [fast/warm reboot] reorder code so that we have a clear main start point - Parse option before checking privilege so all users could get help information. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [fast/warm reboot] add some reboot pre-checks - Make sure that /host has enough space and write-able. - Make sure the next image is available. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix error message
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Added code changes related to Layer 2 Forwarding Enhancement: As part of L2 enhancements, per port, per vlan and per port-vlan fdb flush support has been added. The fdb flush response from SAI comes as individual mac delete as mentioned in the HLD. The change here is to follow the same way for VS as well. Regarding SAI_FDB_EVENT_FLUSHED, it is handled in sync only for 'flush all' case and handling SAI_FDB_EVENT_FLUSHED for per port and per port-vlan will require hgetall on all fdb keys. So, individual mac delete response is preferred. Another change is to move fdb handling to fdborch. As the fdb reference count is now maintained in fdborch as well, need to move the sai redis fdb handling also there to avoid the reference counts to go out of sync between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the lag name and oid mapping to the counter table after the lag is created.
Why I did it
Can not obtain the name of lag by oid when using port_util.get_interface_oid_map(). Causes abnormal display when using show mac command after PortChannel0001 learns mac.
How I verified it
Use redis-cli as below:
127.0.0.1:6379[2]> HGET COUNTERS_PORT_NAME_MAP PortChannel0001
"oid:0x200000000060f"
127.0.0.1:6379[2]>
Details if related