[teamsyncd]: Add team_ifindex2ifname return value check #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
May 10, 2018
teamsyncd/teamsync.cpp
Outdated
| /* Skip if interface is not found */ | ||
| if (!team_ifindex2ifname(m_team, ifindex, ifname, MAX_IFNAME)) | ||
| { | ||
| SWSS_LOG_INFO("Interface ifindex:%d is not found", ifindex); |
There was a problem hiding this comment.
team member interface ifindex(%u) cannot be found.
lguohan
approved these changes
May 10, 2018
Without the return value check, it is possible that ifname is empty due to interface not found. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
prsunny
approved these changes
May 10, 2018
qiluo-msft
approved these changes
May 10, 2018
lguohan
pushed a commit
that referenced
this pull request
May 10, 2018
Without the return value check, it is possible that ifname is empty due to interface not found. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
yangbashuang
pushed a commit
to CentecNetworks/sonic-swss
that referenced
this pull request
May 12, 2018
Without the return value check, it is possible that ifname is empty due to interface not found. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Wenda Ni <wenni@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…#500) * Add support for port remove and port create * Fix aspell dictionary * Remove invalid comments * fix merge issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the return value check, it is possible that ifname is
empty due to interface not found.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com