[orchagent]fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value type mismatch bug #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yangbashuang
changed the title
yxieca
approved these changes
May 9, 2018
There was a problem hiding this comment.
This is a great code clean up change. Thanks for noticing it and making the change.
However, this change in execution doesn't have functional impact. We've used negative dynamic threshold on other platforms without issue.
If you hit issue on your platform, this change shouldn't fix it. What issue did you hit?
|
@yxieca not hit any issue related, i found this issue through code review |
|
@lguohan howto merge this fix to branch 201803? |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value type mismatch bug
Why I did it
according to SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH defination in saibuffer.h:
/**
* @brief Dynamic threshold for the shared usage
*
* The threshold is set to the 2^n of available buffer of the pool.
*
* @type sai_int8_t
* @flags MANDATORY_ON_CREATE | CREATE_AND_SET
* @condition SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE == SAI_BUFFER_PROFILE_THRESHOLD_MODE_DYNAMIC
*/
SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH,
the value type is a sai_int8_t, support negative value
on centec goldengate chip platform, we support range [-7, 3],
but currnetly in swss, uint32 type value is used, have to fix it
How I verified it
Details if related