[PFCWD] Fix ZeroBufferProfile parameters #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
lguohan
approved these changes
Apr 23, 2018
lguohan
pushed a commit
that referenced
this pull request
May 10, 2018
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
wendani
reviewed
May 11, 2019
| @@ -593,7 +593,7 @@ void PfcWdZeroBufferHandler::ZeroBufferProfile::createZeroBufferProfile(bool ing | |||
| attribs.push_back(attr); | |||
|
|
|||
| attr.id = SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH; | |||
| attr.value.u32 = 1; | |||
| attr.value.u32 = -8; // ALPHA_0 | |||
There was a problem hiding this comment.
@andriymoroz-mlnx This usage of alpha == -8, indicating zero shared pool, is MLNX proprietary, not defined/standardized in SAI SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Add STATS_MODE field parsing when oid in FLEX_COUTER_TABLE key is SAI_OBJECT_TYPE_BUFFER_POOL. Use READ_AND_CLEAR mode when either global stats polling mode or the particular buffer pool stats polling mode is READ_AND_CLEAR. In the opposite, use READ mode (no stats clear) only when both global and per buffer pool stats polling mode are READ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
What I did
Fixed used by pfcwd "zero buffer profile" parameters (alpha)
Why I did it
To create proper profile which will drop packets
How I verified it
Create/simulate storm on port, make sure pfcwd assigned "zero profile" on one of it's queues
Details if related