Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD #480

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Apr 20, 2018

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@zhenggen-xu
Copy link
Collaborator

Do you have test results showing UDLD type was working and trapped to the expected priority/queue?

@lguohan lguohan requested a review from qiluo-msft April 22, 2018 23:17
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block the merge until issue has been addressed.

@stcheng
Copy link
Contributor Author

stcheng commented May 10, 2018

this is the corresponding test: sonic-net/sonic-mgmt#607

@lguohan lguohan merged commit 0246df7 into sonic-net:master May 11, 2018
@stcheng stcheng deleted the udld branch May 11, 2018 21:05
yangbashuang pushed a commit to CentecNetworks/sonic-swss that referenced this pull request May 12, 2018
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
…-net#480)

* [syncd_init_common.sh] fix fast reboot backwards compatibility
We should handle both cases for backward-compatible with 201803:
 - fast-reboot
 - SONIC_BOOT_TYPE=fast-reboot
* handle review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants