FdbOrch getPort failed because fdb_entry have no switch_id #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I modified getPort function in FdbOrch, where the key for get_attribute hadn't set switch_id. It was the same for removeFdbEntry. I just added it like addFdbEntry.
Why I did it
I found a bug that mirror didn't work when mirrored to an vlan interface, while ok for port interface.
How I verified it
After checking the syslog, I found ERR that said failed to get bridge port ID, while the entry can be found in DB. Then read the source code and I found that meta_key for fdb_entry was serialized as a whole, so the key string included switch_id, so in our case it failed in checking object_exists.
Details if related
ERR orchagent: :- getPort: Failed to get bridge port ID for FDB entry 00:1b:21:bb:2f:de, rv:-5