Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE #2408

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

preetham-singh
Copy link
Contributor

@preetham-singh preetham-singh commented Aug 6, 2022

Avoid processing portchannel subinterfaces in teamd

What I did
Fixes #11218 : sonic-net/sonic-buildimage#11218

As per Subinterface HLD, portchannel subinterfaces once provisioned by intfmgrd, will be updated to STATE_DB LAG_TABLE.
Teamd subscribes to STATE_DB LAG_TABLE hence it receives portchannel subinterface events though it is not interested in portchannel subinterface events.
Fix is to filter subinterface events prior to adding to teamd event queue.

Why I did it
Fix for issue #11218 where teamd syslog errors were observed when portchannel subinterfaces were configured on the system.

How I verified it
Ensured tlm does not add portchannel subinterface STATE_DB LAG_TABLE events to its event queue thus filtering portchannel subinterface events.

Details if related

Avoid processing portchannel subinterfaces in teamd
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 6, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@prsunny
Copy link
Collaborator

prsunny commented Aug 9, 2022

@preetham-singh , can you please update the title correctly and also better description of the changes. Kindly follow the template and check-mark if the fix is required for any other branch.

@preetham-singh preetham-singh changed the title Fix for issue #11218 tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE Aug 9, 2022
@adyeung
Copy link

adyeung commented Aug 15, 2022

/easycla

@adyeung
Copy link

adyeung commented Aug 16, 2022

@judyjoseph pls help review and signoff

@judyjoseph judyjoseph merged commit 486939a into sonic-net:master Aug 26, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-swss submodule pointer to include the following:
* Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194))
* tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408))
* [counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2360](sonic-net/sonic-swss#2360))
* added support for Xsight platform ([sonic-net#2426](sonic-net/sonic-swss#2426))
* [ci][asan] add DVS tests run with ASAN ([sonic-net#2363](sonic-net/sonic-swss#2363))
* Handle dual ToR neighbor miss scenario ([sonic-net#2151](sonic-net/sonic-swss#2151))
* Upstream new development on p4orch ([sonic-net#2237](sonic-net/sonic-swss#2237))
* [lgtm] Fix dependency ([sonic-net#2419](sonic-net/sonic-swss#2419))
* [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() ([sonic-net#2415](sonic-net/sonic-swss#2415))
* [macsec]: Set MTU for MACsec ([sonic-net#2398](sonic-net/sonic-swss#2398))
* Delete Invalid if condition in intfsorch.cpp ([sonic-net#2411](sonic-net/sonic-swss#2411))

Signed-off-by: dprital <drorp@nvidia.com>
yxieca pushed a commit that referenced this pull request Sep 1, 2022
…ABLE (#2408)

* Fix for issue #11218
Avoid processing portchannel subinterfaces in teamd
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Sep 1, 2022
Update sonic-swss submodule pointer to include the following:
* [BFD]Clean up state_db BFD entries on swss restart ([sonic-net#2434](sonic-net/sonic-swss#2434))
* Fix the Fec Mode Setting of gbsyncd ([sonic-net#2430](sonic-net/sonic-swss#2430))
* [neighsyncd] Enabling ipv4 link local entries for non-dualtor ([sonic-net#2427](sonic-net/sonic-swss#2427))
* tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408))
* PFCWD recovery changes using DLR_INIT ([sonic-net#2316](sonic-net/sonic-swss#2316))
* Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194))

Signed-off-by: dprital <drorp@nvidia.com>
dprital added a commit to dprital/sonic-swss that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants