Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event and alarm management: Add tables for event and alarms. #852

Merged
merged 2 commits into from
May 11, 2024
Merged

Event and alarm management: Add tables for event and alarms. #852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de7796
Add new tables for Event and Alarms.
bhaveshdell Jan 30, 2024
1e750af
Merge branch 'master' into eventd-comm
qiluo-msft May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions common/schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ namespace swss {
#define CHASSIS_APP_DB 12
#define CHASSIS_STATE_DB 13
#define APPL_STATE_DB 14
#define EVENT_DB 19
Copy link
Contributor

@qiluo-msft qiluo-msft May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some redis configuration

# Set the number of databases. The default database is DB 0, you can select
# a different one on a per-connection basis using SELECT <dbid> where
# dbid is a number between 0 and 'databases'-1
databases 16

If the max number is less than 19, will your feature work? Could you break the build prcoess if it happen? #Closed

Copy link
Contributor Author

@bhaveshdell bhaveshdell May 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current max number is set to 100 as part of this change
https://github.com/sonic-net/sonic-buildimage/pull/17161/files#diff-88ce9c28933f9dd9c3009adba8ae67827831c0d7b7ad20c72556ae18b3764931

This feature creates an instance of DB, and the above change to 100 suffices this features requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiluo-msft Please approve/merge this PR if no further comments.


/***** APPLICATION DATABASE *****/

Expand Down Expand Up @@ -567,6 +568,12 @@ namespace swss {
#define APP_FABRIC_MONITOR_DATA_TABLE_NAME "FABRIC_MONITOR_TABLE"
#define APP_FABRIC_MONITOR_PORT_TABLE_NAME "FABRIC_PORT_TABLE"

#define EVENT_HISTORY_TABLE_NAME "EVENT"
#define EVENT_CURRENT_ALARM_TABLE_NAME "ALARM"
#define EVENT_STATS_TABLE_NAME "EVENT_STATS"
#define EVENT_ALARM_STATS_TABLE_NAME "ALARM_STATS"


#ifdef __cplusplus
}
#endif
Expand Down
Loading