[sonic-db-cli]: SONiC DB CLI for DPU objects #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
changed the title
Signed-off-by: Ze Gan <ganze718@gmail.com>
qiluo-msft
reviewed
Dec 4, 2023
| @@ -94,22 +94,24 @@ class RedisReply | |||
|
|
|||
| std::string to_string(); | |||
|
|
|||
| static std::string to_string(redisReply *reply, std::string command = std::string()); | |||
| static std::string to_string(redisReply *reply,const std::string &command = std::string()); | |||
qiluo-msft
reviewed
Dec 4, 2023
|
|
||
| // restore binary pb message to TEST_DB | ||
| EXPECT_EQ(system("cat ./tests/cli_test_data/pb_appliance.bin " |
qiluo-msft
reviewed
Dec 4, 2023
| @@ -93,6 +93,15 @@ CFLAGS_COMMON+=" -fstack-protector-strong" | |||
|
|
|||
| AC_SUBST(CFLAGS_COMMON) | |||
|
|
|||
| AC_CHECK_LIB([dashapi], [PbBinaryToJsonString], [ | |||
| AC_DEFINE(DASH_API_INSTALLED, 1, [Define if DASH API is installed]) | |||
| LIBS="$LIBS -ldashapi" | |||
There was a problem hiding this comment.
swss-common is widely used, it is awkward to ask others to install dashapi.
I see below options:
- remove the dependency on dashapi, and make this PR a generic feature
- refactor sonic-db-cli to support plugin, and develop a new plugin with dashapi dependency
- develop another CLI like sonic-db-dash-cli (just random name).
|
Refactor PR: sonic-net/sonic-dash-api#12 |
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 25, 2024
Add SAG table definition for static anycast gateway. Static anycast gateway HLD [#837](sonic-net/SONiC#837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for PR: sonic-net/sonic-swss#2966
Read DPU objects from Redis via SONiC DB CLI