Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference. #1324

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference. #1324

merged 1 commit into from
Nov 21, 2023

Conversation

Ashish1805
Copy link
Contributor

Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined
2186ac1 
reference.

- In PR sonic-net#1310, a
  constexpt static data member was added. Since sairedis repo uses
  c++14, definition of this data member needs to be provided in .cpp
  file too.
@Ashish1805
Copy link
Contributor Author

@kcudnik I think there is some issue in CodeQL / Analyze (cpp) (pull_request_target) check. It doesn't seem to include the current PR when running the check - rather it runs the check on the head of master that was base for this current PR. This will also explain why check didn't fail for PR #1310 before merge.

@prsunny
Copy link
Contributor

prsunny commented Nov 21, 2023

@kcudnik , we may want to force-merge this.

@kcudnik kcudnik merged commit 9804bd7 into sonic-net:master Nov 21, 2023
13 of 14 checks passed
@Ashish1805 Ashish1805 mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish1805 @prsunny @kcudnik