Fix VDM freeze and unfreeze needed for PM stats collection #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2023
prgeor
reviewed
Oct 18, 2023
prgeor
reviewed
Oct 18, 2023
prgeor
reviewed
Oct 18, 2023
prgeor
reviewed
Oct 18, 2023
prgeor
reviewed
Oct 18, 2023
jaganbal-a
force-pushed
the
master
branch
2 times, most recently
from
6f88bfa
to
0c6ec79
Compare
prgeor
previously approved these changes
Nov 27, 2023
|
@jaganbal-a please check the build failure. its related to your new change |
added 2 commits
November 27, 2023 15:56
…e and unfreeze request needs to be followed. VDM freeze PM stats collection VDM unfreeze
Addressing PR comments. Removed VDM statistics freeze/unfreeze performed inside standard APIs. It should be performed by xcvrd explicitly.
|
@jaganbal-a i think its still failing the build. better to run locally. |
I ran the test cases locally and it is 100% pass, here the criteria fails because of 77% code coverage, the try except coverage test case needs to be added to cover 80+%. |
prgeor
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…In order to collect PM stats without loss of data following vdm freeze and unfreeze request needs to be followed.
VDM freeze
PM stats collection
VDM unfreeze
Description
Currently incorrect order of freeze and unfreeze request is followed to collect PM statistics, with this the data collected prior PM interval will be lost once the unfreeze request is raised before data collection from PM stats register.
Motivation and Context
fixes #386
How Has This Been Tested?
This is tested by dumping the PM table from state-DB for the interface which holds the collected PM stats for each PM interval.