-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic_y_cable] add abstract class YCableBase required for Y-cable API support for multiple vendors #186
Merged
Merged
[sonic_y_cable] add abstract class YCableBase required for Y-cable API support for multiple vendors #186
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1522102
[sonic_y_cable] add abstract class YCableBase required for Y-cable AP…
vdahiya12 5bab021
fix comments
vdahiya12 9fe685a
fix missing comments
vdahiya12 d1dc947
fix corrections
vdahiya12 998f323
fix suggestion
vdahiya12 8a9d6f7
fix comments
vdahiya12 acdb72e
fix the physical_port string;fwfile addition as arg
vdahiya12 b8ff39c
fix more suggestions
vdahiya12 1d3e0a4
fix debug modes def
vdahiya12 66e9647
fix suggestions for case;add new API
vdahiya12 458b62f
fix the api names
vdahiya12 b6bbf82
fix the suggestions
vdahiya12 a4de1c3
fix naming
vdahiya12 2a549ca
add more definitions
vdahiya12 e828a03
fix comments
vdahiya12 8f1018e
fix more suggestions
vdahiya12 9dabc5c
fix comments
vdahiya12 5fcd0b2
push suggestion
vdahiya12 ab18d5f
add more suggest/comments
vdahiya12 5afe8dc
fix constructor
vdahiya12 1e5e2a5
fix comment
vdahiya12 3b7ef85
fix logging
vdahiya12 cc576c9
fix comments for logger
vdahiya12 08cd622
fix delimiter
vdahiya12 df7ee65
fix missing parameter[target] of restart_anlt()
xinyulin 27dc3cf
fix comments; add download status
vdahiya12 5fd135e
fix missing self keyword
xinyulin 5ca5a03
add definition of LOOPBACK_MODE_NONE
vdahiya12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to add something like a colon as a delimiter. E.g,
y_cable_port {}: {}
. Do this for all log functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed