Skip to content

Commit

Permalink
[Component]Fix test_get_firmware_update_notification fail
Browse files Browse the repository at this point in the history
Erro Log:

> pytest_assert(isinstance(notif, STRING_TYPE), "Component {}: Firmware update notification appears to be incorrect from image {}".format(i, image))
E Failed: Component 0: Firmware update notification appears to be incorrect from image current

Refer to API get_firmware_update_notification header, shall return
'None' instead of None.

"""
Retrieves a notification on what should be done in order to complete
the component firmware update

Args:
    image_path: A string, path to firmware image

Returns:
    A string containing the component firmware update notification if required.
    By default 'None' value will be used, which indicates that no actions are required
"""
  • Loading branch information
PJHsieh committed May 16, 2024
1 parent 655a5ff commit 4c40701
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sonic_platform_base/component_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def get_firmware_update_notification(self, image_path):
A string containing the component firmware update notification if required.
By default 'None' value will be used, which indicates that no actions are required
"""
return None
return 'None'

def install_firmware(self, image_path):
"""
Expand Down

0 comments on commit 4c40701

Please sign in to comment.