[dualtor][non-functional] add test template for active-active cable type
#5545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-net#5424) Approach What is the motivation for this PR? Modify testcase test_normal_op.py::test_normal_op_upstream to support parameterization based on cable type(active-active or active-standby). This PR acts as a roadmap on how to support cable type parameterization further for all dualtor_io testcases. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? 1. Add parameterization fixture cable_type. 2. Let existing fixtures for dualtor active-standby selects ports in active-standby cable type to test. 3. List out the basic APIs for active-active tests control/data plane fixtures. How did you verify/test it? Run the test test_normal_op.py::test_normal_op_upstream:
|
This pull request introduces 13 alerts when merging 9dfe02b into 3212c2f - view on LGTM.com new alerts:
|
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
previously approved these changes
Apr 25, 2022
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
previously approved these changes
Apr 28, 2022
|
@zjswhhh did you address the LGTM issues? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request introduces 14 alerts when merging ef53d71 into fcc122b - view on LGTM.com new alerts:
|
|
This pull request introduces 14 alerts when merging 90520fa into 4dc8cfd - view on LGTM.com new alerts:
|
|
@zjswhhh are you able to solve the 14 unused imports identified by LGTM? |
Hi Ying, the alerting for unused import is false positive. Let me check if I can find a work-around. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Submitting this PR to re-add test template for
active-activecable type. The change (#5424) was reverted earlier due to regression.sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Back port request
Approach
What is the motivation for this PR?
Re-add the roadmap for supporting
active-activedualtor_io testcases.How did you do it?
cable_typefixture where the modified fixtures are requested.data_plane_utils.pyto re-useDualtorIOobject.How did you verify/test it?
Tested test cases below, all passed:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation